| NSLW |
Monday 15 June 2009 at 23:30
- [Quote]
|
Rank: Admin

 |
Hello,
I wrote script which installs Supreme Commander/Supreme Commander Forged Alliance. It also can patch (automatically downloading patch or manually selecting it) the game after it's been installed
Wine version : 1.1.23
Distribution : Fedora
Distribution Version : 11 (32 bit)
Graphics card : Nvidia, GeForce 9xxx
Drivers of the graphics card : 185.18.14
Icon for the game:
For script go here Edited by NSLW
|
| Ghostofkendo |
Tuesday 16 June 2009 at 16:53
- [Quote]
|
Rank: Admin

 |
Hi NSLW,
I've got a suggestion for your script: I see that it depends on icoutils which isn't a dependency of POL itself. So shouldn't you add the check_one and POL_SetupWindow_missing couple of commands to warn the user if the icoutils aren't installed ?
Bye
Ghost of Kendo (GoK): You can't spell EVIL without vi 
|
| NSLW |
Tuesday 16 June 2009 at 18:01
- [Quote]
|
Rank: Admin

 |
Citation de Ghostofkendo: it depends on icoutils which isn't a dependency of POL itself. So shouldn't you add the check_one and POL_SetupWindow_missing couple of commands to warn the user if the icoutils aren't installed ?
Hi Ghostofkendo,
wouldn't that check cause installation break?
I don't want to stop installation just because iconutils is required for extracting icon and if there is no iconutils then the only result will be not having nice icon for the game
|
| Ghostofkendo |
Wednesday 17 June 2009 at 0:35
- [Quote]
|
Rank: Admin

 |
Citation de NSLW: wouldn't that check cause installation break?
I don't want to stop installation just because iconutils is required for extracting icon and if there is no iconutils then the only result will be not having nice icon for the game Indeed, using these commands would stop the installation if icoutils aren't installed.
Since you'd prefer to avoid quitting the installation only for that, I would suggest to just add a little warning message at the beginning, telling the user to install these utils before running the script if he wants the icon.
Ghost of Kendo (GoK): You can't spell EVIL without vi 
|
| NSLW |
Wednesday 17 June 2009 at 8:21
- [Quote]
|
Rank: Admin

 |
Citation de Ghostofkendo: I would suggest to just add a little warning message at the beginning, telling the user to install these utils before running the script if he wants the icon.
Thanks  Already done that.
|
| Ghostofkendo |
Wednesday 17 June 2009 at 11:30
- [Quote]
|
Rank: Admin

 |
Just a last little note: in your warning message, you wrote "iconutils" instead of "icoutils" Edited by Ghostofkendo
Ghost of Kendo (GoK): You can't spell EVIL without vi 
|
| NSLW |
Wednesday 17 June 2009 at 11:50
- [Quote]
|
Rank: Admin

 |
Citation de Ghostofkendo: Just a last little note: in your warning message, you wrote "iconutils" instead of "icoutils" 
Indeed  Thanks for pointing that out.
|