Hi Stefan,
My review of your script:
TITLE="$(eval_gettext '3D Train Studio')"
Don't translate $TITLE, it doesn't make much sense and to make it into the repository it has to match the name of the script anyway, so it must be a constant.
URL="$(eval_gettext 'http://www.3d-train.com')"
Don't translate URLs, doesn't make sense either
POL_SetupWindow_Init
Just after that you should also enable the embedded debugger:
POL_SetupWindow_Init
POL_Debug_Init
# Install mandatory prerequisites
POL_SetupWindow_wait "Please wait while installing prerequisites." "$TITLE"
POL_Call POL_Install_tahoma2
But on the other hand all user-oriented messages have to support translation!
The comment is redundant, so doesn't really improve readability...
POL_SetupWindow_browse "Please select the setup file to run." "$TITLE"
POL_SetupWindow_wait "Please wait while $TITLE is installed." "$TITLE"
Again, translate all user-oriented messages. You can also replace the latter with
POL_Wine_WaitBefore "$TITLE"
that will display this exact standard waiting message.
POL_Wine start /unix "$APP_ANSWER"
POL_Wine_WaitExit "$TITLE"
"start /unix" is not necessary 95% of the time, and it has a bad side effect: the application will not be automatically killed if the installation is aborted from PlayOnLinux/PlayOnMac. So if it's not necessary, remove it.
If it works, you may find that POL_Wine_WaitBefore is sufficient and that you can drop POL_Wine_WaitExit too.
Regards,
Pierre.
Edytowane przez petch