Das Forum

Warcraft III - The Frozen Throne 1.22a

Autor Antworten
gargamel Saturday 7 February 2009 at 16:32

Hi all,

A little message to tell you that I have committed and validated a new POL script to allow the installation of 1.22a patch for "Warcraft III - The Frozen Throne".

Please, fill free to test the script and give your feedback on it.

It supports i18n of Warcraft III, and is able to apply the right patch if user locales are set correctly.

Nevertheless, their is a limitation on "Chinese Simplified", "Chinese Traditional" and "Taiwanese" patch versions. Because the locales respectively set for those 3 languages are : zh_CN, zh_HK and zh_TW, if I'm right. Therefore, as POL computes POL_LANG by getting the output of `echo "$LANG" | cut -d\_ -f 1', for those 3 different languages, POL_LANG, while always be set to "zh" ! And here is the problem, with POL_LANG set as it is set at the moment, it is impossible to differentiate "Chinese Simplified" from "Chinese Traditional" from "Taiwanese" ! So a future fix about this would be good.

Hope you like this script. Have a good game !

Ghostofkendo Saturday 7 February 2009 at 23:03

Hi gargamel,

Thank you for your contribution but I see that your script is still in a "non-validated" state.
So I would like to know who told you it was validated. If it's just an error, I can validate it else I can check it myself.

gargamel Sunday 8 February 2009 at 18:35

Hi Ghostofkendo,

I'm quite surprised by your message.

First of all, I'm a newby POL scripts committer, but a long time POL user. Last week, I discovered (thanks to marieuh) that it was possible for any user to commit scripts, in the scripts section. Therefore, I committed 3 new POL scripts : "Diablo II : LoD 1.12a patch", "Fire Department 2" and "Warcraft III : TFT 1.22a patch". Then, the 3 POL scripts entered the state : "in-editing" scripts. I validated two of them, the blizzard patch installers (by clicking the "validate" link). Scripts I tested successfully on my W3TFT and D2LoD installs. For the last script, I left it in "in-editing" state, because I've to update it to POL v3 API.

So my understanding of POL scripts states was simple:
- in-editing : The commiter (anybody) can still make changes to his script. Nobody can use
it. POL script only available to committer.
- non-validated : The committer clicked the button "validate", considering its scripts as
ready to be tested and committed to the repo by the admins.
- validated : Admins accepted the script and will commit it to the repo and therefore
will gave all POL users the ability to use the script.
In my opinion, I thought that before this step only admins could see the script.

So has I told you, I'm surprised by your message. You seem to say that I shoudn't have validated my scripts. I thought first that it was a POL admin reserved action. But as long as a validate button was available for me (little member) I thought I could validate my production. On my point of view, I thought, testing would come next, and my script would be set as "validated" by an Admin. But it seems that I didn't understand anything. I'm sorry

I will be delighted to better understand POL scripts commit process.

Ghostofkendo Sunday 8 February 2009 at 18:53

But it seems that I didn't understand anything. I'm sorry

Quote from gargamel
No, you don't have to be sorry! You understood very well. It's just me who misunderstood when you wrote "I have committed and validated".
For me, "validated" was meaning "accepted by a script writer/admin" and since your script was still in a non-validated state, I was wondering why

So now things are clearer, someone from POL staff (maybe me) will check your scripts and accept them if they're correct.